Fix C# codegen for tail-recursive member functions #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpitclaudel
force-pushed
the
cpitclaudel_2173
branch
from
752719b
to
461791a
Compare
MikaelMayer
previously approved these changes
Jun 6, 2022
| @@ -1331,7 +1331,9 @@ protected class ClassWriter : IClassWriter { | |||
| protected override ConcreteSyntaxTree EmitTailCallStructure(MemberDecl member, ConcreteSyntaxTree wr) { | |||
| Contract.Assume((member is Method m0 && m0.IsTailRecursive) || (member is Function f0 && f0.IsTailRecursive)); // precondition | |||
| if (!member.IsStatic && !NeedsCustomReceiver(member)) { | |||
| wr.WriteLine("var _this = this;"); | |||
| var receiverType = member.EnclosingClass is DatatypeDecl dt ? | |||
| "_I" + dt.CompileName + TypeParameters(SelectNonGhost(dt, dt.TypeArgs)) : "var"; | |||
There was a problem hiding this comment.
Oh I see, since the fields stores an interface, you need to provide the interface for the base type. Nice and easy fix.
fabiomadge
previously approved these changes
Jun 7, 2022
Comment on lines
+1336
to
+1337
| var receiverType = member.EnclosingClass is DatatypeDecl dt ? DtTypeName(dt) : "var"; | ||
| wr.WriteLine($"{receiverType} _this = this;"); |
There was a problem hiding this comment.
Suggested change
| var receiverType = member.EnclosingClass is DatatypeDecl dt ? DtTypeName(dt) : "var"; | |
| wr.WriteLine($"{receiverType} _this = this;"); | |
| wr.Write(member.EnclosingClass is DatatypeDecl dt ? DtTypeName(dt) : "var"); | |
| wr.WriteLine(" _this = this;"); |
fabiomadge
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2173.