Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use {:test} and {:synthesize} in automatically generated tests #2269

Merged
merged 9 commits into from
Jul 12, 2022

Conversation

Dargones
Copy link
Collaborator

This PR makes test generation code produce methods annotated with {:test} and {:synthesize}, which can then be automatically compiled to C# by the Dafny compiler (and in future to other languages). This approach is much simpler than the one previously used, which is to manually insert Java reflection code.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

atomb
atomb previously approved these changes Jun 17, 2022
Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement. Thanks!

RELEASE_NOTES.md Outdated Show resolved Hide resolved
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
atomb
atomb previously approved these changes Jun 17, 2022
@Dargones
Copy link
Collaborator Author

Thank you for catching the typo, @atomb! Have committed it (but that dismisses the review)

@Dargones
Copy link
Collaborator Author

Dargones commented Jul 5, 2022

Thank you for updating this, @MikaelMayer! The failing test (EnsuresPriorityWorksEvenIfRemovingMethodsWhileTypo) seems to be unrelated to this PR and failing for some of the recent commits to master as well. Am I right that it must have something to do with the Language Server?

@MikaelMayer
Copy link
Member

Thank you for updating this, @MikaelMayer! The failing test (EnsuresPriorityWorksEvenIfRemovingMethodsWhileTypo) seems to be unrelated to this PR and failing for some of the recent commits to master as well. Am I right that it must have something to do with the Language Server?

Yes you are right. @keyboardDrummer and I are working hard to resolve the bug here:
#2352
So basically, you can just wait. Thanks for your patience.

@robin-aws robin-aws merged commit 57810f0 into dafny-lang:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants