Solution to issue 2265 related to erroneous substitution under bindin… #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtristan
added
kind: bug
cpitclaudel
requested changes
Sep 14, 2022
There was a problem hiding this comment.
Great fix! A few suggestions:
- There are still a few whitespace-only changes in unrelated parts of the code that would be nice to undo
- I think this PR is missing a fix for the
if-casepattern that @RustanLeino sent an example of in the original issue discussion (if x :| P(x) => …) - The split-quantifiers case isn't quite right, I think — but the original code was broken too (!)
- I've left other small comments in the code
|
With respect to the additional issue raised by Rustan involving a case statement, I decided to create a new issue because even if the fix might be small and simple, I would first like to make sure I understand the semantics, and I will add a new corresponding test. |
jtristan
force-pushed
the
issue_2265
branch
from
001219d
to
8c84c60
Compare
cpitclaudel
requested changes
Sep 16, 2022
cpitclaudel
previously approved these changes
Sep 16, 2022
cpitclaudel
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g guards
Fixes #2265
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.