Make a clone of the parsed document available in compilation #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
Jan 9, 2023
| @@ -938,8 +938,8 @@ public class ModuleDefinition : INode, IDeclarationOrUsage, INamedRegion, IAttri | |||
| public override IEnumerable<INode> Children => (Attributes != null ? new List<INode> { Attributes } : Enumerable.Empty<INode>()).Concat(TopLevelDecls); | |||
| } | |||
|
|
|||
| public class DefaultModuleDecl : ModuleDefinition { | |||
| public DefaultModuleDecl() | |||
| public class DefaultModuleDef : ModuleDefinition { | |||
There was a problem hiding this comment.
Ahhhhhh I was wondering why I was always confused by module declarations and module definitions.... you nailed it !
MikaelMayer
reviewed
Jan 9, 2023
| var symbolTable = symbolTableFactory.CreateFrom(program, compilationUnit, cancellationToken); | ||
| var textDocument = documentAfterParsing.TextDocumentItem; | ||
| var parsedProgram = documentAfterParsing.Program; | ||
| var clonedProgram = new Program(parsedProgram.Name, |
There was a problem hiding this comment.
Oops the cloning removes all the ranges and owned tokens, that means that the parsed document will be useless for formatting... I don't think we can get around solving #3290 now
There was a problem hiding this comment.
Can we not just clone those as well? Not cloning them seems like a bug
There was a problem hiding this comment.
Yes, but since they are not part of the constructor, we might forget about them, either in current cloners, in future cloners, or in future language constructs. Anyway, we can add the range manually for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.