Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Cok retry induction tests (#3307)" #3364

Merged

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Jan 13, 2023

I see nightly is failing again: https://github.com/dafny-lang/dafny/actions/runs/3909011490/jobs/6679674161

I'm guessing it's because of the following commit, since that's what caused the exact same issue, namely the win-4 run timing out, so I'll revert that: 790bf78.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer added the run-deep-tests Tells CI to run all tests label Jan 13, 2023
Copy link
Collaborator

@stefan-aws stefan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and simple revert to find the root-cause of nightly failing. Fine to me.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) January 13, 2023 11:38
@keyboardDrummer keyboardDrummer merged commit 1a9f7a0 into dafny-lang:master Jan 13, 2023
@keyboardDrummer keyboardDrummer deleted the revertInductionTest branch January 13, 2023 11:52
davidcok pushed a commit to davidcok/dafny that referenced this pull request Jan 18, 2023
I see nightly is failing again:
https://github.com/dafny-lang/dafny/actions/runs/3909011490/jobs/6679674161

I'm guessing it's because of the following commit, since that's what
caused the exact same issue, namely the win-4 run timing out, so I'll
revert that: 790bf78.

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
davidcok pushed a commit to davidcok/dafny that referenced this pull request Jan 20, 2023
I see nightly is failing again:
https://github.com/dafny-lang/dafny/actions/runs/3909011490/jobs/6679674161

I'm guessing it's because of the following commit, since that's what
caused the exact same issue, namely the win-4 run timing out, so I'll
revert that: 790bf78.

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-deep-tests Tells CI to run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants