Stop creating dafny options (expensive) more than once #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rummer/dafny into stopCreatingDafnyOptionsMidway
davidcok
approved these changes
Feb 15, 2023
keyboardDrummer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop creating dafny options (expensive) midway during normal operation, this makes the OSX tests complete in about 25 minutes as opposed to 60.
Reduces the runtime of
EnsuresPriorityDependsOnEditingWhileEditingSameMethodby about 50%. I expect most other language server tests will be positively affected as well.#3233 introduced code that starts a Z3 process being started whenever
DafnyOption.Create()is called, which makes it slow, so such calls such be avoided in hot areas.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.