Chore: Fix Gradle build flagging Java 8 compatibility as "obsolete" #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks every other CI
robin-aws
requested changes
Jun 15, 2023
There was a problem hiding this comment.
We need to be careful that we're not breaking compatibility of the runtime with Java 8 with this change, or that it didn't happen already. I think sourceCompatibility is fine to change since it only affects maintainers, but does this mean targetCompatibility was already automatically upgraded?
robin-aws
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Removing -warnaserror is definitely the lesser evil, and we need to unblock CI, so approved. I think this bumps #1983 up in priority though. I commented on a strategy I think we can use now: #1983 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, every other PR cannot be merged.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.