Fix: Support for opaque function handles #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
requested changes
Jun 21, 2023
| @@ -5845,7 +5853,7 @@ void CheckCasePatternShape<VT>(CasePattern<VT> pat, Bpl.Expr rhs, IToken rhsTok, | |||
| } | |||
|
|
|||
| { | |||
| // Requires(Ty.., F#Handle( Ty1, ..., TyN, Layer, self), Heap, arg1, ..., argN) | |||
| // Requires(Ty.., F#Handle( Ty1, ..., TyN, Layer, reveal, self), Heap, arg1, ..., argN) | |||
There was a problem hiding this comment.
Based on my initial experiments, this should make it easier to allow all functions to have a reveal parameter. The fact that requires didn't have this parameter was an awkward asymmetry.
There was a problem hiding this comment.
To be fair, we add the reveal parameter to the handle version of the function, not its requires. Since requirements and postconditions are always revealed, there is no need for a reveal parameter in .reveal
Co-authored-by: Aaron Tomb <aarotomb@amazon.com>
atomb
previously approved these changes
Jun 21, 2023
atomb
approved these changes
Jun 22, 2023
MikaelMayer
deleted the
fix-4202-opaque-functions-passed-as-arguments-causes-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4202
I added the corresponding test.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.