feat: Benchmarking plugin (take two) #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a compiler plugin to implement support for a class-level
`{:benchmarks}` attribute. See `DafnyBenchmarkingPlugin/README.md` for
details.
Since the existing plugin interface didn't support this use case, and
we'd like it to so other similar features like `{:test}` and coverage
instrumentation can also be plugins in the future, I also added a new
`CompilerInstrumenter` plugin interface similar to `Rewriter`.
The integration test for this plugin is also a negative test for
dafny-lang#1454, which will be fixed in
a separate pending PR.
<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
---------
Co-authored-by: Remy Willems <rwillems@amazon.com>
atomb
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoes #4215, which had to be reverted. Weakens the test that caused trouble due to the non-determinism of benchmarking (see second commit).
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.