Various fixes for project aware mode #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into virtualFilesystem
alex-chew
reviewed
Jul 21, 2023
Source/DafnyLanguageServer/Workspace/LanguageServerFilesystem.cs
Outdated
Show resolved
Hide resolved
alex-chew
previously approved these changes
Jul 24, 2023
alex-chew
previously approved these changes
Jul 24, 2023
alex-chew
approved these changes
Jul 24, 2023
keyboardDrummer
added a commit
to keyboardDrummer/dafny
that referenced
this pull request
Sep 15, 2023
Depends on dafny-lang#4273 ### Changes 1. Take URIs into account when handling manual verification run and cancellation requests 1. Enable project aware mode option 1. Send compilation status updates for all documents owned by a project 1. Do not retrigger compilation of a project when opening an unchanged document of that project ### Tests 1. Add test `RunWithMultipleSimilarDocuments` 1. No test needed 1. Add test `CompilationStatusNotificationTest.MultipleDocuments` 1. Performance, difficult to test without an existing framework <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
the referenced file {uri.LocalPath} contains error(s) but is not owned by this project. The first error is: {errors.First().Message}Tests
Skipattribute from two existing testsRunWithMultipleSimilarDocumentsCompilationStatusNotificationTest.MultipleDocumentsBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.