Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some of the know logical inconsistencies #4348

Merged
merged 25 commits into from
Aug 4, 2023
Merged

Fixing some of the know logical inconsistencies #4348

merged 25 commits into from
Aug 4, 2023

Conversation

jtristan
Copy link
Contributor

Fixes #

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@jtristan jtristan marked this pull request as draft July 27, 2023 22:50
@jtristan jtristan self-assigned this Jul 27, 2023
@jtristan jtristan requested a review from RustanLeino August 2, 2023 21:42
Copy link
Collaborator

@RustanLeino RustanLeino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!
I left many C# comments, which I hope you'll find helpful.

Test/Landin/Knot1.dfy Show resolved Hide resolved
Test/Landin/Knot10.dfy Outdated Show resolved Hide resolved
Test/Landin/Knot12.dfy Outdated Show resolved Hide resolved
Test/Landin/Knot10.dfy Outdated Show resolved Hide resolved
Test/Landin/Knot10.dfy Outdated Show resolved Hide resolved
@jtristan jtristan marked this pull request as ready for review August 4, 2023 02:37
@jtristan jtristan requested a review from RustanLeino August 4, 2023 02:37
@jtristan jtristan enabled auto-merge (squash) August 4, 2023 02:37
@jtristan jtristan merged commit 22550f8 into master Aug 4, 2023
@jtristan jtristan deleted the LogicFix branch August 4, 2023 20:57
keyboardDrummer pushed a commit to keyboardDrummer/dafny that referenced this pull request Sep 15, 2023
Fixes #

<!-- Is this a user-visible change? Remember to update RELEASE_NOTES.md
-->

<!-- Is this a bug fix? Remember to include a test in Test/git-issues/
-->

<!-- Is this a bug fix for an issue introduced in the latest release?
Mention this in the PR details and ensure a patch release is considered
-->

<!-- Does this PR need tests? Add them to `Test/` or to
`Source/*.Test/…` and run them with `dotnet test` -->

<!-- Are you moving a large amount of code? Read CONTRIBUTING.md to
learn how to do that while maintaining git history -->

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer pushed a commit that referenced this pull request Sep 19, 2023
Fixes #

<!-- Is this a user-visible change? Remember to update RELEASE_NOTES.md
-->

<!-- Is this a bug fix? Remember to include a test in Test/git-issues/
-->

<!-- Is this a bug fix for an issue introduced in the latest release?
Mention this in the PR details and ensure a patch release is considered
-->

<!-- Does this PR need tests? Add them to `Test/` or to
`Source/*.Test/…` and run them with `dotnet test` -->

<!-- Are you moving a large amount of code? Read CONTRIBUTING.md to
learn how to do that while maintaining git history -->

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants