Support all option types in the project file #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
commented
Sep 1, 2023
| } | ||
| errorWriter.WriteLine( | ||
| $"Error: property '{tomlPath}' is of type '{tomlValue.GetType()}' but should be of type '{type}'"); | ||
| var parseResult = option.Parse(new[] { option.Aliases.First(), tomlValue }); |
There was a problem hiding this comment.
This will parse the project file options in the same way as the CLI parses them, so there won't be any discrepancy any more.
MikaelMayer
reviewed
Sep 1, 2023
| ghost function Bar(): int { 3 }".TrimStart(); | ||
|
|
||
| var projectFileSource = @" | ||
| includes = [""**/*.dfy""] | ||
|
|
||
| [options] | ||
| warn-shadowing = false | ||
| quantifier-syntax = 4 |
There was a problem hiding this comment.
In your test, could you please add an option that was otherwise translated to an enum or otherwise processed?
For example:
test-assumptions = externs
It serves no purpose for your example other than testing that the parsing mechanism works (which it did not until this PR)
There was a problem hiding this comment.
quantifier-syntax is an enum type option, even though it looks like an int. If I just add test-assumptions = externs without testing its effects, then it's not testing much is it?
There was a problem hiding this comment.
Oh great, you got my point and that's perfect then.
MikaelMayer
previously approved these changes
Sep 5, 2023
…ardDrummer/dafny into supportAllOptionTypesInProjectFile
…ardDrummer/dafny into supportAllOptionTypesInProjectFile
MikaelMayer
previously approved these changes
Sep 8, 2023
| @@ -9,7 +9,7 @@ Warning: only Dafny project files named dfyconfig.toml are recognised by the Daf | |||
| Warning: option 'does-not-exist' that was specified in the project file, is not a valid Dafny option. | |||
|
|
|||
| Dafny program verifier did not attempt verification | |||
| Error: property 'warn-shadowing' is of type 'System.Int64' but should be of type 'System.Boolean' | |||
| Error: Could not parse value '3' for option 'warn-shadowing' that has type 'Boolean' | |||
…ardDrummer/dafny into supportAllOptionTypesInProjectFile
MikaelMayer
previously approved these changes
Sep 11, 2023
keyboardDrummer
added a commit
to keyboardDrummer/dafny
that referenced
this pull request
Sep 15, 2023
### Changes - Support all option types in the project file by parsing the project file options in the same way as the CLI parses them ### Testing - Added a case that uses an enum option to an existing test <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 15, 2023
### Changes - Support all option types in the project file by parsing the project file options in the same way as the CLI parses them ### Testing - Added a case that uses an enum option to an existing test <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
|
Wow thanks @keyboardDrummer! I just tested it, the feature I implemented can finally be accessed easily. I'm super happy :D |
keyboardDrummer
added a commit
that referenced
this pull request
Sep 19, 2023
### Changes - Support all option types in the project file by parsing the project file options in the same way as the CLI parses them ### Testing - Added a case that uses an enum option to an existing test <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer
added a commit
that referenced
this pull request
Sep 19, 2023
### Changes - Support all option types in the project file by parsing the project file options in the same way as the CLI parses them ### Testing - Added a case that uses an enum option to an existing test <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
zafer-esen
pushed a commit
that referenced
this pull request
Sep 25, 2023
### Changes - Support all option types in the project file by parsing the project file options in the same way as the CLI parses them ### Testing - Added a case that uses an enum option to an existing test <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.