Allow not migrating legacy symbols #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-aws
approved these changes
Oct 18, 2023
robin-aws
pushed a commit
that referenced
this pull request
Oct 18, 2023
### Description Attempt at making `QuickEditsInLargeFile` pass more reliably on OSX ### How has this been tested? It's a change intended to affect the existing test `QuickEditsInLargeFile` <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt at making
QuickEditsInLargeFilepass more reliably on OSXHow has this been tested?
It's a change intended to affect the existing test
QuickEditsInLargeFile. I couldn't get a C# profiler to work locally so I don't have good data on whether this works or not, but previous profiling sessions showed this legacy symbol table as a big contributor to starving the threadpool.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.