Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compilation target for PHP #470

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Add compilation target for PHP #470

merged 2 commits into from
Jan 8, 2020

Conversation

scottarc
Copy link
Contributor

@scottarc scottarc commented Jan 2, 2020

This PR adds a compilation target (with an enum value of 16), but does not define a Compiler-php.cs file. That will follow shortly.

@robin-aws
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: Dafny
  • Commit ID: a00418f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@scottarc
Copy link
Contributor Author

scottarc commented Jan 2, 2020

******************** TEST 'Dafny :: server/git-issue223.transcript' FAILED ********************

Very interesting...

@robin-aws
Copy link
Member

robin-aws commented Jan 7, 2020 •
edited
Loading

******************** TEST 'Dafny :: server/git-issue223.transcript' FAILED ********************

Very interesting...

This seems to be a regression in master that only shows up in CodeBuild AFAICT, likely introduced by #459. I'm looking into it now.

See #476 for updates.

@robin-aws
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: Dafny
  • Commit ID: 587b318
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RustanLeino RustanLeino merged commit 2617870 into dafny-lang:master Jan 8, 2020
@scottarc scottarc deleted the target-php branch January 8, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottarc @robin-aws @RustanLeino