-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Optimize Go imports): run goimports on Go target code #4777
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
9ad39a8
feat(Optimize Go imports): run goimports on Go target code
ShubhamChaturvedi7 c8b7166
Merge branch 'dafny-lang:master' into master
ShubhamChaturvedi7 2b03658
fix(docs): Update the Installation.md for Go
ShubhamChaturvedi7 2ed2b92
Merge branch 'master' into master
ShubhamChaturvedi7 79b2a41
fix(CI): Go get goimports
ShubhamChaturvedi7 2c31098
Merge branch 'master' into master
ShubhamChaturvedi7 375b49b
fix(CI): Go install goimports
ShubhamChaturvedi7 977f05b
fix(CI): Use setup-go for goimports
ShubhamChaturvedi7 9821ca0
Merge branch 'master' into master
ShubhamChaturvedi7 418ca76
fix(CI Tests): Diff formatting fix
ShubhamChaturvedi7 2f07ff4
Merge branch 'dafny-lang:master' into master
ShubhamChaturvedi7 5308135
Merge branch 'master' into master
ShubhamChaturvedi7 1a7edcf
fix(CI): Install goimports for Go 1.11
ShubhamChaturvedi7 4561a2e
fix(CI): Install goimports for Go 1.20
ShubhamChaturvedi7 397910f
fix(Review): Comments
ShubhamChaturvedi7 8ec957f
Merge branch 'master' into master
ShubhamChaturvedi7 cf2bb36
fix(CI): Use the min compatible version of Go for CI
ShubhamChaturvedi7 5df8644
fix(CI): Use GO111MODULE=auto
ShubhamChaturvedi7 c2ade99
fix(CI): Use GO111MODULE=on
ShubhamChaturvedi7 8092f3c
Merge branch 'master' into master
ShubhamChaturvedi7 5cd7107
Merge branch 'master' into master
ShubhamChaturvedi7 5782838
Merge branch 'master' into master
robin-aws 9d24383
fix(CI): Fixes CHECK directive across Go Versions
ShubhamChaturvedi7 fa31f66
Merge branch 'master' into master
ShubhamChaturvedi7 1e4b095
Merge branch 'master' into master
ShubhamChaturvedi7 9b86632
Merge branch 'master' into master
ShubhamChaturvedi7 1935f0b
Merge branch 'master' into master
ShubhamChaturvedi7 899cb5d
Merge remote-tracking branch 'aws/master'
ShubhamChaturvedi7 55eb801
fix(CI): Merge conflict fix
ShubhamChaturvedi7 2b5aafa
Merge branch 'dafny-lang:master' into master
ShubhamChaturvedi7 36af5f7
Use ioutil instead of os in Go Std extern code
robin-aws bac9d4e
Merge branch 'master' into master
robin-aws 0ba2131
Merge branch 'master' into master
robin-aws 15050d8
Typo
robin-aws e19d9ba
Merge remote-tracking branch 'aws/master'
ShubhamChaturvedi7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it these changes are because
goimports
applies auto-formatting as well?No issues with that and in fact that's kind of a nice side-effect of this change!