Fix: Dafny server API for counterexamples #5847
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
requested changes
Oct 21, 2024
| @@ -4,12 +4,14 @@ | |||
| namespace Microsoft.Dafny.LanguageServer.Handlers.Custom { | |||
| public class CounterExampleItem { | |||
| public Position Position { get; } | |||
| public IDictionary<string, string> Variables { get; } | |||
|
|
|||
| public string Assumption { get; } | |||
There was a problem hiding this comment.
Do you intend the Assumption field to be used by the IDE? Otherwise better not to have it and reduce bandwidth.
|
I brought back the old tests, the ones that test |
|
@keyboardDrummer would you know how to fix the tests? |
|
@keyboardDrummer @MikaelMayer The old tests use an entirely different interface, so they won't help at all. The way to go is to edit existing tests manually one by one. I can do this but it might take me a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes dafny-lang/ide-vscode#492
The language sever currently crushes when asking to display counterexamples. This is because #5013 changed the way counterexamples are represented but the IDE still expects the old representation. This PR fixes this. The IDE will now display any constraints that equate some literal to a variable/field/function application, etc. Here are some examples:
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.