Fix: Tail-recursion for result copy types in the Dafny-to-Rust backend. #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
changed the title
keyboardDrummer
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5923 completely, irrespective of the type of output variables.
The previous fix was only not redeclaring output variables when they were wrapped with
MaybePlacebo, which is reserved for output variables that don't have a trivial initialization.This fixes #5923 entirely by just ensuring we don't place output variables as part of the environment of recursive methods, since the
TailRecursive(...)body already declares themHow has this been tested?
A new test added to
rust/newtypes.dfyBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.