-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use C# 12 features #6070
base: master
Are you sure you want to change the base?
Use C# 12 features #6070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like the primary constructors! But isn't it technically less safe when you convert a readonly field to a primary constructor parameter, since they're always writeable?
Good point. You can make them readonly by prefixing them with |
I've removed that commit now, and did a few manual applications of primary constructors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What was changed?
How has this been tested?
No additional tests needed, since this is a pure refactoring
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.