Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: avoid reinstalling dafny-reportgenerator #61

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

alex-chew
Copy link
Contributor

@alex-chew alex-chew commented Nov 11, 2022

As of setup-dafny-action@v1.5.0, dafny-reportgenerator is installed automatically, so our test workflow fails when it also tries to install the tool. This PR removes the installation step from the test workflow.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

As of setup-dafny-action@v1.5.0, dafny-reportgenerator is installed automatically, so our test workflow fails when it also tries to install the tool. This PR removes the installation step from the test workflow.
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the new dafny actions are already installing the report generator, more specifically version 1.0.0
We could have run a command that check if it's already installed but for now that would be useless, so let's do as you suggested.

@alex-chew alex-chew merged commit b9bc178 into master Nov 11, 2022
@alex-chew alex-chew deleted the no-reportgenerator-reinstall branch November 11, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants