feat: implement Error trait for all error types #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genedna
approved these changes
Nov 20, 2023
Signed-off-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
Signed-off-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
Signed-off-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
Signed-off-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
auto-merge was automatically disabled
November 20, 2023 00:26
Head branch was pushed to by a user without write access
|
Signed the commits so that auto-merge works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
thiserror::Errorfor all error types of the package. This has many benefits such as the possibility to use?, standard conversion to/from other error types, and simplification of error handling.