feat!: use the standard rustlang log for all logging purposes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING this replaces the custom logging implementation with the standard rust-lang/log library that is implemented for many backends https://github.com/rust-lang/log Signed-off-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
Signed-off-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
Signed-off-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
genedna
approved these changes
Nov 27, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the custom logging implementation with the standard rust-lang/log library that is implemented for many backends.
This has many benefits. There are a huge number of loggers that already implement this standard logging interface. There is no need to reinvent the wheel for logging. It also simplifies the code in this library as we will not need to maintain the custom logging facade.
Another benefit is that logging becomes optional automatically, and the user is not forced to implement/initialize logging.
This logging interface is also more efficient as it uses compile-time macros for logging. So, it will not create strings when not needed.
https://github.com/rust-lang/log