Skip to content

Commit

Permalink
Register dagster-polars in DagsterLibraryRegistry (#19910)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Community PR adding dagster-polars was merged but did not add it to
`DagsterLibraryRegistry`, causing a failure on BK.
  • Loading branch information
smackesey authored Feb 20, 2024
1 parent ac01b0f commit 00516c1
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_resource_telemetry():
libraries = [
library.name.replace("-", "_")
for library in os.scandir(libraries_dir)
if not library.name.endswith("CONTRIBUTING.md")
if not (library.name.startswith(".") or library.name.endswith("CONTRIBUTING.md"))
]
libraries.append("dagster")

Expand Down
2 changes: 1 addition & 1 deletion python_modules/automation/automation_tests/test_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def test_all_libraries_register() -> None:
assert str(library_dir).endswith("python_modules/libraries")

for library in os.listdir(library_dir):
if library.endswith("CONTRIBUTING.md"):
if library.startswith(".") or library.endswith("CONTRIBUTING.md"):
continue
result = subprocess.run(["grep", register_call, (library_dir / library), "-r"], check=False)
assert (
Expand Down
1 change: 1 addition & 0 deletions python_modules/automation/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ deps =
-e ../libraries/dagster-snowflake-pandas
-e ../libraries/dagster-snowflake-pyspark
-e ../libraries/dagster-pandera
-e ../libraries/dagster-polars
-e .

# This is a temporary pin due to version conflicts between dbt 1.6 and some higher-order
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from dagster._core.libraries import DagsterLibraryRegistry

from dagster_polars.io_managers.base import BasePolarsUPathIOManager
from dagster_polars.io_managers.parquet import PolarsParquetIOManager
from dagster_polars.types import (
Expand Down Expand Up @@ -44,3 +46,5 @@
__all__.extend(["PolarsBigQueryIOManager", "PolarsBigQueryTypeHandler"])
except ImportError:
pass

DagsterLibraryRegistry.register("dagster-gcp", __version__)

0 comments on commit 00516c1

Please sign in to comment.