-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected GraphQL Error for Schedules #11794
Comments
prha
added a commit
that referenced
this issue
Jan 27, 2023
### Summary & Motivation We were using `packaging.parse` to compare mysql server versions, which broke when `0.23.0` was released with dropped support for `LegacyVersion`. This rolls our own custom version compares to find minimum supported versions, which is tolerant of non semver compliant version strings. The regex parses all the numeric values, and does tuple int comparisons. Reported in #11794 Reference links: pypa/packaging#407 ### How I Tested These Changes Added some test cases that override the server version string to exercise the parsing logic.
gibsondan
pushed a commit
that referenced
this issue
Jan 27, 2023
### Summary & Motivation We were using `packaging.parse` to compare mysql server versions, which broke when `0.23.0` was released with dropped support for `LegacyVersion`. This rolls our own custom version compares to find minimum supported versions, which is tolerant of non semver compliant version strings. The regex parses all the numeric values, and does tuple int comparisons. Reported in #11794 Reference links: pypa/packaging#407 ### How I Tested These Changes Added some test cases that override the server version string to exercise the parsing logic.
This should be resolved now with dagster release If upgrading is not an option, you could also pin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dagster version
1.1.10
What's the issue?
Unexpected GraphQL Error when opening the Schedule screen or any asset on Dagit.
What did you expect to happen?
Schedules and assets are displayed correctly.
The schedules work.
Additional information
This involves the use of MySQL storage to persist the metadata.
For the local dev, I added a MySQL container to my
docker-compose
, and everything was running smoothly.But for deployment, I used the MySQL instance of my company on AWS RDS.
It's working (the metadata is persisted in the MySQL database created for the occasion) BUT there is this specific error appearing on any asset page or on the schedule page. And the schedules don't work.
The MySQL version of the RDS is
5.7.38
so I don't know where thelog
(in5.7.38-log
) is coming from.How to reproduce?
I tried to reproduce it locally but failed.
The text was updated successfully, but these errors were encountered: