Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbt werkzeug incompatability issue #1807

Closed
schrockn opened this issue Oct 4, 2019 · 2 comments
Closed

dbt werkzeug incompatability issue #1807

schrockn opened this issue Oct 4, 2019 · 2 comments

Comments

@schrockn
Copy link
Member

schrockn commented Oct 4, 2019

Right now we have some sort of conflict between flask and dbt requiring different werkzeug versions.

ERROR: flask 1.1.1 has requirement Werkzeug>=0.15, but you'll have werkzeug 0.14.1 which is incompatible.
Installing collected packages: werkzeug, dbt-core
  Found existing installation: Werkzeug 0.16.0
    Uninstalling Werkzeug-0.16.0:
      Successfully uninstalled Werkzeug-0.16.0
  Running setup.py install for dbt-core ... done
Successfully installed dbt-core-0.14.2 werkzeug-0.14.1
(fresh-oct-3) [schrockn@mbp ~/code/dagster/examples (master *)]$ dagit
Traceback (most recent call last):
  File "/Users/schrockn/venvs/fresh-oct-3/bin/dagit-cli", line 6, in <module>
    from dagit.cli import main
  File "/Users/schrockn/venvs/fresh-oct-3/lib/python3.7/site-packages/dagit/cli.py", line 15, in <module>
    from .app import create_app
  File "/Users/schrockn/venvs/fresh-oct-3/lib/python3.7/site-packages/dagit/app.py", line 13, in <module>
    from flask import Flask, request, send_file, send_from_directory
  File "/Users/schrockn/venvs/fresh-oct-3/lib/python3.7/site-packages/flask/__init__.py", line 21, in <module>
    from .app import Flask
  File "/Users/schrockn/venvs/fresh-oct-3/lib/python3.7/site-packages/flask/app.py", line 69, in <module>
    from .wrappers import Request
  File "/Users/schrockn/venvs/fresh-oct-3/lib/python3.7/site-packages/flask/wrappers.py", line 14, in <module>
    from werkzeug.wrappers.json import JSONMixin as _JSONMixin
ModuleNotFoundError: No module named 'werkzeug.wrappers.json'; 'werkzeug.wrappers' is not a package
schrockn added a commit that referenced this issue Oct 4, 2019
@schrockn
Fix requirements.txt and comment out problematic pipelines to get dag…
9ac40d7 
…ster/examples working against public modules

Summary:
This is to get our examples working on a fresh public install.

Two follow-up issues:

#1806
#1807

Test Plan: Create fresh venv. Launch dagit in dagster/examples

Reviewers: #ft, natekupp, sashank

Reviewed By: #ft, sashank

Differential Revision: https://dagster.phacility.com/D1212
@mgasner
Copy link
Contributor

mgasner commented Oct 7, 2019

We're going to prioritize Flask over dbt for this and pin to werkzeug>=0.15.0 explicitly in examples. Ultimately, we can probably eliminate dbt-core from setup.py for both the examples and for dagster-dbt -- we don't call the dbt Python APIs at all, just shell out to dbt. Making this invocation configurable will allow dbt to be installed in a separate virtualenv. See for discussion in the dbt Slack: https://getdbt.slack.com/archives/C2JRRQDTL/p1570473192496400

@mgasner
Copy link
Contributor

mgasner commented Oct 7, 2019

There is an open issue to upgrade dbt's dependency. dbt-labs/dbt-core#1697

@mgasner mgasner closed this as completed in d9b1421 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgasner @schrockn