Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully enable Python 3.8 tests #1960

Closed
natekupp opened this issue Dec 6, 2019 · 2 comments
Closed

Fully enable Python 3.8 tests #1960

natekupp opened this issue Dec 6, 2019 · 2 comments
Labels
Milestone

Comments

@natekupp
Copy link
Contributor

natekupp commented Dec 6, 2019

With https://dagster.phacility.com/D1560 we are adding tests for Python 3.8.

However, any test that requires pyarrow or pyspark won't work right now, so I haven't added SupportedPython.V3_8 to SupportedPythons.

Once we can support 3.8 fully, we should add 3.8 to supported Pythons and clean up special casing. I'll leave comments in the code linking to this issue where that is necessary.

natekupp pushed a commit that referenced this issue Dec 6, 2019
Summary:
This enables Python 3.8 tests for most things in Dagster.

See: #1960 for notes on what's not currently covered.

Test Plan: unit

Reviewers: schrockn, alangenfeld, max, prha

Reviewed By: max

Differential Revision: https://dagster.phacility.com/D1560
@mgasner mgasner added the test label Dec 6, 2019
@mgasner mgasner mentioned this issue Dec 11, 2019
mgasner pushed a commit that referenced this issue Jan 10, 2020
Summary:
This enables Python 3.8 tests for most things in Dagster.

See: #1960 for notes on what's not currently covered.

Test Plan: unit

Reviewers: schrockn, alangenfeld, max, prha

Reviewed By: max

Differential Revision: https://dagster.phacility.com/D1560
@natekupp
Copy link
Contributor Author

natekupp commented Mar 16, 2020

This is almost ready to go: https://dagster.phacility.com/D2261

@natekupp natekupp added this to the 0.9.0 (planned) milestone Jun 1, 2020
sd2k added a commit to sd2k/dagster that referenced this issue Jun 5, 2020
sd2k added a commit to sd2k/dagster that referenced this issue Jun 8, 2020
sd2k added a commit to sd2k/dagster that referenced this issue Jun 8, 2020
sryza pushed a commit that referenced this issue Jun 9, 2020
* Add dagster-databricks package

This package is closely modeled off the dagster_aws.emr subpackage and
provides the databricks_pyspark_step_launcher resource and the
DatabricksRunJobSolidDefinition solid for running Databricks jobs.

* Reference Databricks docs in dagster-databricks configs module

* Move build_pyspark_zip into dagster_pyspark utils module

* Fix style/minor issues in dagster-databricks

Specifically:

- triple single quotes instead of triple double quotes for docstrings
- single quotes instead of double quotes everywhere else
- oneline docstrings where possible; start on same line everywhere else
- rename 'is_terminal' to 'has_terminated'
- use 'databricks_run_id' instead of 'run_id' for clarity
- make DatabricksJobRunner.client a property
- remove unnecessary blank lines

* Add references to Databricks storage docs in 'main' script

* Add comment explaining global vars in databricks_step_main.py

* Fix Python 2 issues in dagster-databricks

* Check invariants when setting up storage in Databricks job

* Fix dependencies in dagster-databricks/tox.ini

* Move 'secret_scope' field into inner credentials object to simplify Databricks storage

* isort dagster-databricks

* Add pylint to tox.ini for dagster_databricks

* Install dagster-databricks in 'make install_dev_python_modules'

* Reference GitHub issue for better storage setup in databricks_step_main.py

* Uncomment dagster-azure related config

* Replace assert_called_once with call_count for Python3.5 compat

* Fix lint errors in databricks.py

* Improve handling of libraries by including required libs by default

* Fix version to match other dagster libraries

* Specify supported_pythons to exclude Python 3.8 from dagster-databricks tests on buildkite

See #1960.

* Add README for dagster-databricks

* Install dagster-databricks in dagster-examples tox.ini

* Update snapshot test for dagster example using databricks

* Add API docs for dagster_databricks

* Add coveragerc for dagster-databricks
@natekupp
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants