Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin graphql-core to <3 #1549

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Pin graphql-core to <3 #1549

merged 2 commits into from
Jul 12, 2019

Conversation

jkimbo
Copy link
Contributor

@jkimbo jkimbo commented Jul 12, 2019

We're planning on releasing a new major release of graphql-core with some breaking changes (dropping Python 2 support for example). This PR pins the version of graphql-core to be less than v3 so that nothing breaks when this happens.

@schrockn
Copy link
Member

This is incredible love and care thank you.

There is an additional reference to this in python_modules/dagit/requirements.txt

@jkimbo
Copy link
Contributor Author

jkimbo commented Jul 12, 2019

@schrockn done 😄

Copy link
Member

@alangenfeld alangenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - just working out the kinks in our external contrib CI workflow before merging

@alangenfeld alangenfeld merged commit 9009f97 into dagster-io:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants