Add --no-cache option to run_pyright script #24212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @smackesey and the rest of your teammates on |
smackesey
commented
Sep 4, 2024
| nvidia-cusparse-cu12==12.1.0.106 | ||
| nvidia-nccl-cu12==2.20.5 | ||
| nvidia-nvjitlink-cu12==12.6.20 | ||
| nvidia-nvtx-cu12==12.1.105 |
There was a problem hiding this comment.
Removal is unrelated to this PR, but these shouldn't be here
benpankow
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The
uvcache can cause subtle problems sometimes when rebuilding pyright environments. Rebuilding envs without using the cache can fix an apparently intractable problem. This PR adds--no-cacheas an arg torun-pyright.py. This is intended for rare use as an escape hatch for pyright env problems-- it makes rebuilding the envs much more slow.See this issue I posted over at
uvfor some info about why you might want to use this: astral-sh/uv#7028How I Tested These Changes
My pyright was (unresolvable imports for all dagster packages). After rebuilding my env with
--no-cachethe problem went away. The issue was that the cache seemed to be holdingpthfiles for our dagster editables that did not respecteditable_mode=compatand were incorrectly formatted for pyright.Changelog [New | Bug | Docs]
NOCHANGELOG