[dagit] Downgrade @apollo/client #6291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). dagster – ./docs/next🔍 Inspect: https://vercel.com/elementl/dagster/7j9wFNvFoyRJnStq7k3Tk9Fzmc3h dagit-storybook – ./js_modules/dagit/packages/ui🔍 Inspect: https://vercel.com/elementl/dagit-storybook/FCLkDW4rNR7n8nE4bXLkGfSDXhvq |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
bengotow
approved these changes
Jan 21, 2022
|
Just in case we come back to this later: These are the two issues we encountered: This is a repo with two branches reproducing each case with a minimal "fruit info" graphQL API: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems like there must have been a change in
@apollo/client3.5.x that broke some of our existing software-defined assets query behavior.Downgrading to 3.3.16 (where we were previously) resolves the issue.
Test Plan
View http://localhost:3000/workspace/software_defined_assets@repo.py/jobs/spark_weather/, verify that I can filter assets without crashing the page.