Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#840] config: fix: Add dagsDir config key #850

Merged
merged 3 commits into from
Feb 19, 2025
Merged

[#840] config: fix: Add dagsDir config key #850

merged 3 commits into from
Feb 19, 2025

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Feb 19, 2025

Issue: #840

Changes:

  • Added dagsDir config key
  • Added tests for config load
  • Added todo for config refactor

@yohamta yohamta merged commit ec38f7e into main Feb 19, 2025
4 checks passed
@yohamta yohamta deleted the 840-config-load branch February 19, 2025 14:49
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.62%. Comparing base (09a89c5) to head (91b1d9e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   55.48%   55.62%   +0.14%     
==========================================
  Files          75       75              
  Lines        8170     8174       +4     
==========================================
+ Hits         4533     4547      +14     
+ Misses       3241     3227      -14     
- Partials      396      400       +4     
Files with missing lines Coverage Δ
internal/config/config.go 80.80% <100.00%> (+11.01%) ⬆️
internal/config/loader.go 78.20% <100.00%> (+0.09%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a89c5...91b1d9e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant