Skip to content

Commit

Permalink
feat(template-mcps): configure helm revision env (acryldata#518)
Browse files Browse the repository at this point in the history
  • Loading branch information
david-leifker authored Nov 7, 2024
1 parent 1edccec commit 6849c2c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart for DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.4.34
version: 0.4.35
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.14.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ spec:
{{- end }}
- name: {{ $v.values_env }}
value: {{ $result | toJson | quote }}
{{- with $v.revision_env }}
- name: {{ . }}
value: '{"version":"{{ $.Chart.Version }}-{{ $.Release.Revision }}"}'
{{- end }}
{{- end }}
{{- with .Values.datahubSystemUpdate.extraEnvs }}
{{- toYaml . | nindent 12 }}
Expand Down Expand Up @@ -313,6 +317,10 @@ spec:
{{- end }}
- name: {{ $v.values_env }}
value: {{ $result | toJson | quote }}
{{- with $v.revision_env }}
- name: {{ . }}
value: '{"version":"{{ $.Chart.Version }}-{{ $.Release.Revision }}"}'
{{- end }}
{{- end }}
{{- with .Values.datahubSystemUpdate.extraEnvs }}
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 2 additions & 0 deletions charts/datahub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -408,10 +408,12 @@ datahubSystemUpdate:
- "datahub.systemUpdate.datahubGC.timezone"
# Environment variable containing the json value for the template mcp
values_env: DATAHUB_GC_BOOTSTRAP_VALUES
revision_env: DATAHUB_GC_BOOTSTRAP_REVISION
# Base values for the template mcp
values:
ingestion:
name: datahub-gc
version: "0.14.1.7rc2"
schedule:
# overridden by global.datahub.timezone
timezone: "UTC"
Expand Down

0 comments on commit 6849c2c

Please sign in to comment.