chore: update pytest workflow. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rainwoodman
commented
Dec 13, 2024
•
rainwoodman
commented
- We shall run developer install after the python environment is set up.
- Use on: pull_request instead the unsafe and broken on: pull_request_target. We are running arbitrary code and we do not need secretes like GITHUB_TOKEN. (I am not sure about why lintPR.yaml workflow requires it, but if it onlly lints then there is no arbitrary execution to exploit)
- now that the workflow actually works, remove the dependency on typing_extension to fix the installation error.
rainwoodman
changed the title
This hides secrects like GITHUB_TOKEN, which we do not need.
TypedDict is in Python proper since like 3.8. or 3.9. But also read
https://news.ycombinator.com/item?id=21307640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.