Adds support for shorthand force-push syntax #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git supports a short-hand syntax for force-pushing a branch to a remote by including the "+" modifier before the branch name. However when doing so, Posh-git was no longer able to auto-complete the branch name as it did not understand this syntax. This PR adds that support. Closes dahlbyk#173
|
Any chance of this making it in @dahlbyk? |
| @@ -223,6 +223,11 @@ function GitTabExpansion($lastBlock) { | |||
| "^push.* (?<remote>\S+) (?<ref>[^\s\:]*\:)(?<branch>\S*)$" { | |||
| gitRemoteBranches $matches['remote'] $matches['ref'] $matches['branch'] | |||
| } | |||
|
|
|||
| # Handles git push remote +<branch> (force push) | |||
| "^push.* (?<remote>\S+) (?<ref>\+)(?<branch>\S*)$" { | |||
There was a problem hiding this comment.
I don't think this is quite what we want... This will capture the + in the ref group and try matching remote branches based on that.
I think it would be sufficient to add \+? above/below before we capture <ref>:<branch> or just <branch> - give that a try?
|
So sorry for the delay in looking at this, @dan-turner. I appreciate you looping back around to bump it, as this is definitely something we should support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git supports a short-hand syntax for force-pushing a branch to a remote by including the "+" modifier before the branch name. However when doing so, Posh-git was no longer able to auto-complete the branch name as it did not understand this syntax. This PR adds that support.
Closes #173