-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all git calls to capture STDERR properly #183
Conversation
…ompt()" This reverts commit 1a1f186.
@@ -299,6 +299,7 @@ if (Test-Path Function:\TabExpansion) { | |||
} | |||
|
|||
function TabExpansion($line, $lastWord) { | |||
"line: $line, lastWord: $lastWord" > c:\dev\333.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Sorry for the delay in looking at this - really nice work! I'm going to give this a try locally, but everything makes sense at a glance. Can you add a note to |
@@ -133,7 +133,7 @@ function Write-GitStatus($status) { | |||
Write-Prompt $s.AfterText -BackgroundColor $s.AfterBackgroundColor -ForegroundColor $s.AfterForegroundColor | |||
|
|||
if ($WindowTitleSupported -and $s.EnableWindowTitle) { | |||
if( -not $Global:PreviousWindowTitle ) { | |||
if (-not (Test-Path -Path Variable:Global:PreviousWindowTitle)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you apply this strict revision to elseif ( $Global:PreviousWindowTitle )
below? Getting this:
The variable '$Global:PreviousWindowTitle' cannot be retrieved because it has not been set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Cool, fixes look good. Going to run with this for today and see if anything seems out of sorts. |
@rkeithhill @lzybkr what do you think about this PR? |
Take a look at my comment on the related issue - #182. With 0.6.1, I can't repro the issue this PR is meant to fix. Can you? I simply see the |
Fixes #182