Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #298 #299

Merged
merged 2 commits into from
Aug 14, 2016
Merged

fix #298 #299

merged 2 commits into from
Aug 14, 2016

Conversation

JimAmuro
Copy link
Contributor

use System.IO.Path]::GetTempPath() instead of $env:temp to get rid of 8.3 filename problem

@JimAmuro
fix #298
7b6d082 
use `System.IO.Path]::GetTempPath()` instead of `$env:temp` to get rid of 8.3 filename problem
@dahlbyk
Copy link
Owner

dahlbyk commented Aug 12, 2016

There's another use of $Env:TEMP on line 231. Maybe extract a Get-TempEnvPath($key) function to use in both places?

@dahlbyk dahlbyk merged commit c39da78 into dahlbyk:master Aug 14, 2016
@dahlbyk
Copy link
Owner

dahlbyk commented Aug 14, 2016

Thanks!

@JimAmuro JimAmuro deleted the patch-1 branch August 14, 2016 14:39
@eliassal eliassal mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimAmuro @dahlbyk