Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to EnvironmentVariableTarget. #318

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Remove reference to EnvironmentVariableTarget. #318

merged 1 commit into from
Dec 6, 2016

Conversation

rkeithhill
Copy link
Collaborator

Fix #317. This type is not defined in .NET Core 1.0/1.1. Even though it is coming back in .NET Core 1.2, our use isn't necessary because the SetEnvironmentVariable(string name, string value) overload defaults to setting the variable for the current process even on Linux/macOS. See https://docs.microsoft.com/en-us/dotnet/core/api/system.environment#System_Environment_SetEnvironmentVariable_System_String_System_String_

Fix #317.  This type is not defined in .NET Core 1.0/1.1.  Even though it is coming back in .NET Core 1.2, our use isn't necessary because the SetEnvironmentVariable(string name, string value) overload defaults to setting the variable for the current process even on Linux/macOS.  See https://docs.microsoft.com/en-us/dotnet/core/api/system.environment#System_Environment_SetEnvironmentVariable_System_String_System_String_
@rkeithhill rkeithhill merged commit 867b1ee into dahlbyk:master Dec 6, 2016
@rkeithhill rkeithhill deleted the rkeithhill/fix-pscore-related-issues branch December 6, 2016 04:50
@dahlbyk dahlbyk mentioned this pull request Dec 29, 2016
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant