Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed prompt workaround #357

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Renamed prompt workaround #357

merged 1 commit into from
Jan 6, 2017

Conversation

dahlbyk
Copy link
Owner

@dahlbyk dahlbyk commented Jan 5, 2017

Fix #355, regression from #349.

The Chocolatey install writes some extra stuff to $PROFILE to try to preserve an existing prompt function. I'm not really a fan of that behavior, but until we can try to clean that up we need to make sure that we're not broken if prompt doesn't exist (presumably because it has been renamed).

So if we find that prompt doesn't exist, we create a new global one that we promptly override.

@dahlbyk dahlbyk requested a review from rkeithhill January 5, 2017 06:03
@dahlbyk dahlbyk added this to the v0.7 milestone Jan 5, 2017
Copy link
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dahlbyk dahlbyk merged commit 18d600a into master Jan 6, 2017
@dahlbyk dahlbyk deleted the renamed-prompt-workaround branch January 6, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants