Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF8 Everywhere #359

Merged
merged 4 commits into from
Jan 6, 2017
Merged

UTF8 Everywhere #359

merged 4 commits into from
Jan 6, 2017

Conversation

dahlbyk
Copy link
Owner

@dahlbyk dahlbyk commented Jan 6, 2017

Builds on #223 (belated thanks, @matarillo!) to parse all Git output as UTF8, including tab completion.

Before

UTF8 Before

After

UTF8 After
(no console emojis = 😞)

I don't think I missed anywhere? Modifications were optimized for avoiding huge indentation-only changes.

@dahlbyk dahlbyk added this to the v0.7 milestone Jan 6, 2017
Copy link
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants