Adds aliasing support for TortoiseGit commands #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allows configuration of TortoiseGit commands
dahlbyk
requested changes
Feb 2, 2017
src/GitTabExpansion.ps1
Outdated
| @@ -194,7 +194,7 @@ function GitTabExpansionInternal($lastBlock) { | |||
| # Handles tgit <command> (tortoisegit) | |||
| if ($lastBlock -match "^$(Get-AliasPattern tgit) (?<cmd>\S*)$") { | |||
| # Need return statement to prevent fall-through. | |||
| return $tortoiseGitCommands | Where-Object { $_ -like "$($matches['cmd'])*" } | |||
| return $Global:TortoiseGitSettings.TortoiseGitCommands.Keys.GetEnumerator() | sort | Where-Object { $_ -like "$($matches['cmd'])*" } | |||
There was a problem hiding this comment.
s/sort/Sort-Object/
(also in TortoiseGit.ps1)
There was a problem hiding this comment.
Good catch. PowerShell Core running on Linux or macOS does not have the sort alias defined for Sort-Object. So calling sort would execute the native sort utility.
src/TortoiseGit.ps1
Outdated
| "subupdate" = "subupdate"; | ||
| "switch" = "switch"; | ||
| "checkout" = "switch"; | ||
| "sync" = "sync"; |
There was a problem hiding this comment.
Would it make sense to alias fetch to sync?
src/TortoiseGit.ps1
Outdated
| "sync", | ||
| "repostatus" | ||
| ) | sort | ||
| } |
There was a problem hiding this comment.
EOL @ EOF, please!
(Tip: we have a .editorconfig that will enforce this for supported editors.)
Changes % -> ForEach-Object Adds fetch alias for sync
dahlbyk
approved these changes
Feb 3, 2017
|
💯 👏 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows configuration of TortoiseGit commands