Fix #448 SignatureType enum not available on PS v2 #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now rely on the SignerCertificate field to be $null. If it isn't $null, then we assume the profile is signed and we don't modify it. Note that this field is not $null when the file is signed but there is a hash mismatch (which is the desired behavior). Fix #448.
rkeithhill
force-pushed
the
rkeithhill/is448-signaturetype-not-on-v2
branch
from
0d51c87
to
588e293
Compare
It was introduced after 0.7.0 shipped so no need to document it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now rely on the SignerCertificate field to be $null. If it isn't $null, then we assume the profile is signed and we don't modify it. Note that this field is not $null when the file is signed but there is a hash mismatch (which is the desired behavior). Fix #448