Write-Prompt with $null colors, plus respecting DefaultForegroundColor #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write-Prompt -ForgroundColorbeing required has frustrated me for a while, as has capturing the$Host.UI.RawUIcolor values when$GitPromptSettingsis initialized (meaning posh-git looks wrong if those values are changed after the module is loaded. So I've made-ForegroundColoroptional, and defaulted the appropriate settings to$null.I've also started respecting
DefaultForegroundColoragain, to align with what I did kind of by accident in #447 (because-ForegroundColorwas required). The setting was introduced as a hack for colored Git commands messing with$Host.UI.RawUI.ForegroundColor(02956e1). More recently, it was removed in #202 and restored in #209 to avoid a breaking change. However, since we have it, I suppose we might as well support using it to control the default prompt text color.