Pass "git.exe" instead of "git" to Get-Command #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing just "git" to get-command causes the script to fail if you have an alias called "git". For example, I have hub installed (https://github.com/github/hub), which recommends aliasing git=hub. However, after doing this it breaks this posh-git script because `get-command git` returns the new alias which has no path. Running `get-command git` returns: CommandType Name Version Source ----------- ---- ------- ------ Alias git -> hub.exe But `get-command git.exe` returns: CommandType Name Version Source ----------- ---- ------- ------ Application git.exe 2.13.2.1 C:\Program Files\Git\cmd\git.exe
mikesigs
changed the title
|
This works for me. There's a small chance this is a regression for folks with an older version of Git, which may have only put |
|
(Thanks!) |
|
My pleasure. Good call on looking for *git.cmd*. I suppose the script could
be updated to look for both variants.
…On Mon, 10 Jul 2017 at 16:41 Keith Dahlby ***@***.***> wrote:
(Thanks!)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#478 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAxgqWoaFcGQJFaU0-F5QCy7p2UFLGA9ks5sMqidgaJpZM4OTfYU>
.
|
|
I expect |
|
A bit further digging and I would have this much better fix:
Get-Command git -CommandType Application
…On Mon, 10 Jul 2017 at 16:45 Keith Dahlby ***@***.***> wrote:
I expect Get-Command git.exe,git.cmd -ErrorAction SilentlyContinue would
do the trick?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#478 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAxgqTW8ZtioYCbjUaUpHeqnqhybQCnYks5sMqmdgaJpZM4OTfYU>
.
|
mikesigs
added a commit
to mikesigs/posh-git
that referenced
this pull request
Jul 10, 2017
Related dahlbyk#478. This is a better fix. By specifying the CommandType as Application we can continue looking for `git` (exe or cmd) but avoiding any potential aliases the user may have created for "git".
|
Unfortunately this (original fix in this PR) won't work when running posh-git on PS Core on Linux / macOS:
|
|
A better fix for this is to use the |
dahlbyk
pushed a commit
that referenced
this pull request
Jan 10, 2018
Related #478. This is a better fix. By specifying the CommandType as Application we can continue looking for `git` (exe or cmd) but avoiding any potential aliases the user may have created for "git".
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing just "git" to
get-commandcauses the script to fail if you have an alias called "git". For example, I have hub installed , which recommends aliasing git=hub. However, after doing this it breaks this posh-git script becauseget-command gitreturns the new alias which has no path.Running
get-command gitreturns:CommandType Name Version Source
But
get-command git.exereturns:CommandType Name Version Source