Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move develop (v1) to master #568

Merged
merged 163 commits into from
Apr 20, 2018
Merged

Move develop (v1) to master #568

merged 163 commits into from
Apr 20, 2018

Conversation

dahlbyk
Copy link
Owner

@dahlbyk dahlbyk commented Apr 20, 2018

As discussed (#522 (comment)), v0.x development has moved from master to v0. This bring v1 progress on develop into master as our main line of development.

We've already reviewed everything except the last two commits.

rkeithhill and others added 30 commits February 18, 2017 14:34
Also doing some miscellaneous cleanup (remove Invoke-NullCoalescing, remove testDebugHarness.ps1 in favor of using the Pester Tests debug configuration, rename CheckVersion.ps1 to CheckRequirements.ps1).
Also add PrereleaseVersion as module private data property.  Might come in handy.

I'll update the issue template on master and then submit a PR to merge master to develop.
Update develop (1.0) from master (0.7.1)
- Make Set-ConsoleMode a no-op on non-Windows
- Suppress a lint warning
- Remove unused functions
Semantics are still quite strange...
- If -Builder is specified (piped in), it will be returned, but only
  modified if -AnsiConsole is also specified
- If -AnsiConsole is specified, a string with ANSI color escape sequences
  is returned.
- Otherwise, an empty string is returned.
Use ANSI color codes if SupportsVirtualTerminal
24-bit support depends on System.Drawing for parsing HTML color strings.
Update develop from master
ANSI 256-color and 24-bit color support
Passing just "git" to get-command causes the script to fail if you have an alias called "git". For example, I have hub installed (https://github.com/github/hub), which recommends aliasing git=hub. However, after doing this it breaks this posh-git script because `get-command git` returns the new alias which has no path.

Running `get-command git` returns:
CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Alias           git -> hub.exe

But `get-command git.exe` returns:
CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     git.exe                                            2.13.2.1   C:\Program Files\Git\cmd\git.exe
rkeithhill and others added 22 commits March 1, 2018 20:28
Fix bug w/setting fg/bg color to 0x0 & add regression test
…ings-display

Enhance $GitPromptSettings to display RGB in hex, better spacing
Add $global:PoshGitLastPrompt for ANSI escaped prompt str
Implement $GitPromptSettings.UntrackedFilesMode in the develop branch.
Also modified ANSI tests to be consistent and not flatten $res with
string interpolation.  Catch more errors this way.
Update to prompt func to allow path/status order swap
@dahlbyk dahlbyk requested a review from rkeithhill April 20, 2018 05:10
[string[]]$RepositoriesInWhichToDisableFileStatus = @()

[string]$DescribeStyle = ''
[psobject]$WindowTitle = {param($GitStatus, [bool]$IsAdmin) "$(if ($IsAdmin) {'Administrator: '})$(if ($GitStatus) {"posh~git ~ $($GitStatus.RepoName) [$($GitStatus.Branch)] ~ "})PowerShell $($PSVersionTable.PSVersion) $([IntPtr]::Size * 8)-bit ($PID)"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes from PR #567

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll retarget #567 to master after this is merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha

@dahlbyk dahlbyk merged commit a8adab2 into master Apr 20, 2018
@dahlbyk dahlbyk deleted the develop-to-master branch April 20, 2018 05:31
@rkeithhill
Copy link
Collaborator

I did a dir diff on this branch with develop and there wasn't much except in some of top-level md files and the psd1 1.0.0 vs 1.0.0.0 (branch names in URLS).

image

@dahlbyk
Copy link
Owner Author

dahlbyk commented Apr 20, 2018

I did a dir diff on this branch with develop and there wasn't much except in some of top-level md files and the psd1 1.0.0 vs 1.0.0.0 (branch names in URLS).

That's what I would expect. I assume most of what you see aligns with what GitHub shows on 3e4509e?

I reverted the version back to 1.0.0.0 as an indicator that a bug report's coming from a clone of posh-git, rather than an official release (which will have 1.0.0). Or did we decide that isn't necessary?

@rkeithhill
Copy link
Collaborator

I "think" it's still necessary because module versioning at the PowerShell level (vs PSGallery/PowerShellGet) is still using .NET's System.Version and can't indicate pre-prelease info in the version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants