-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move develop (v1) to master #568
Conversation
Also doing some miscellaneous cleanup (remove Invoke-NullCoalescing, remove testDebugHarness.ps1 in favor of using the Pester Tests debug configuration, rename CheckVersion.ps1 to CheckRequirements.ps1).
Also add PrereleaseVersion as module private data property. Might come in handy. I'll update the issue template on master and then submit a PR to merge master to develop.
Remove PowerShell v2 support.
Update develop (1.0) from master (0.7.1)
Remove obsolete funtion Enable-GitColors.
Update develop from master
Hat tip to @lzybkr
- Make Set-ConsoleMode a no-op on non-Windows - Suppress a lint warning - Remove unused functions
Semantics are still quite strange... - If -Builder is specified (piped in), it will be returned, but only modified if -AnsiConsole is also specified - If -AnsiConsole is specified, a string with ANSI color escape sequences is returned. - Otherwise, an empty string is returned.
Use ANSI color codes if SupportsVirtualTerminal
24-bit support depends on System.Drawing for parsing HTML color strings.
Update develop from master
ANSI 256-color and 24-bit color support
Update develop from master
Passing just "git" to get-command causes the script to fail if you have an alias called "git". For example, I have hub installed (https://github.com/github/hub), which recommends aliasing git=hub. However, after doing this it breaks this posh-git script because `get-command git` returns the new alias which has no path. Running `get-command git` returns: CommandType Name Version Source ----------- ---- ------- ------ Alias git -> hub.exe But `get-command git.exe` returns: CommandType Name Version Source ----------- ---- ------- ------ Application git.exe 2.13.2.1 C:\Program Files\Git\cmd\git.exe
Fix bug w/setting fg/bg color to 0x0 & add regression test
…ings-display Enhance $GitPromptSettings to display RGB in hex, better spacing
Add $global:PoshGitLastPrompt for ANSI escaped prompt str
…n the develop branch.
Implement $GitPromptSettings.UntrackedFilesMode in the develop branch.
Also modified ANSI tests to be consistent and not flatten $res with string interpolation. Catch more errors this way.
Update to prompt func to allow path/status order swap
Update develop from master
[string[]]$RepositoriesInWhichToDisableFileStatus = @() | ||
|
||
[string]$DescribeStyle = '' | ||
[psobject]$WindowTitle = {param($GitStatus, [bool]$IsAdmin) "$(if ($IsAdmin) {'Administrator: '})$(if ($GitStatus) {"posh~git ~ $($GitStatus.RepoName) [$($GitStatus.Branch)] ~ "})PowerShell $($PSVersionTable.PSVersion) $([IntPtr]::Size * 8)-bit ($PID)"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing changes from PR #567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll retarget #567 to master
after this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha
That's what I would expect. I assume most of what you see aligns with what GitHub shows on 3e4509e? I reverted the version back to 1.0.0.0 as an indicator that a bug report's coming from a clone of posh-git, rather than an official release (which will have 1.0.0). Or did we decide that isn't necessary? |
I "think" it's still necessary because module versioning at the PowerShell level (vs PSGallery/PowerShellGet) is still using .NET's System.Version and can't indicate pre-prelease info in the version number. |
As discussed (#522 (comment)), v0.x development has moved from
master
tov0
. This bring v1 progress ondevelop
intomaster
as our main line of development.We've already reviewed everything except the last two commits.