-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance PoshGitTextSpan support for custom VT seqs #616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm thinking perhaps we should just ditch the
CustomAnsi
property and allow folks to put as much custom seqs in theText
field as their heart desires.
👍
I'll fix the tests tonight. First, I wanted to see if you agreed in principle to this change. |
Oh yeah baby, fixed the AppVeyor tests. I submit a separate PR for that. |
d064df1
to
49557be
Compare
@dahlbyk This is ready for a final review/merge. |
One thing I wonder about the current impl is that if the user embeds VT seqs in the |
ab6c4b9
to
0ef31b8
Compare
Update PoshGitCellColor to show "#" as a swatch char for a FG VT sequence.
0ef31b8
to
ccc5630
Compare
@dahlbyk See what you think about this. In the process of explaining for #612 how to use the
CustomAnsi
property onPoshGitTextSpan
to customize built-in prompt, I realized my previous impl of this idea was too limiting. For instance before the Path is display the user wanted this displayed in the prompt:The ideal property to use for this info is the
$GitPromptSettings.DefaultPromptPrefix
but there are four different bits of info displayed with different colors. That currently does NOT work.My original idea with
CustomAnsi
was that folks could specify a custom sequence that would apply to the text. That would allow the user to set other attributes like say underline or inverse as well as fg/bg colors. But that sequence would apply to all of the text so you could have only a single span of text with those attributes.Now I'm thinking perhaps we should just ditch the
CustomAnsi
property and allow folks to put as much custom seqs in theText
field as their heart desires. For instance, with this change, I can achieve the above desired display with this one setting:Thoughts?