-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(status): Only reset changed colors #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, @ExE-Boss. I've been focused on wrapping up a big project.
I can reproduce the build failure on master
, so I'll merge as soon as we can get that resolved. Thanks for the contribution!
That build failure seems to be because apt-get is failing to install PowerShell on Ubuntu 14.04. Any chance we could migrate the build to 16.04 since 14.04 is EOL in 10 days? Install instructions for 16.04 are here - https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-core-on-linux?view=powershell-6#installation-via-package-repository---ubuntu-1604 |
Co-Authored-By: Keith Hill <r_keith_hill@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This fixes a bug with using posh‑git inside a PowerLine block, which would result in the background colour being reset to the PowerShell window’s background colour, breaking the PowerLine block.
review?(@dahlbyk): I’ve been using this for the last 15 days, and it works fine for me.