Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put 'CACHE ERROR' in prompt when cache returns failure. #759

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

cmarcusreid
Copy link
Collaborator

Follow-up from #755

image

This diff is a bit unfortunate; the only new bit is the leading if block. The rest was indented in the new else block.

@rkeithhill
Copy link
Collaborator

rkeithhill commented Apr 7, 2020

Fortunately, you can diff this in VSCode with the GitHub Pull Requests extension. And because VSCode diffs allow you to ignore whitespace, this diff simplifies to:

image

@cmarcusreid
Copy link
Collaborator Author

TIL! Thanks!

@rkeithhill
Copy link
Collaborator

rkeithhill commented Apr 7, 2020

I really wish GitHub would offer the option to ignore whitespace changes in diffs. This is one area where Bitbucket has a leg up on GH.

@rkeithhill rkeithhill requested a review from dahlbyk April 7, 2020 21:56
@rkeithhill
Copy link
Collaborator

Thanks for the PR! I've asked the other Keith to review it before merging it.

@dahlbyk
Copy link
Owner

dahlbyk commented Apr 8, 2020

Thanks for the fix, @cmarcusreid!

I really wish GitHub would offer the option to ignore whitespace changes in diffs. This is one area where Bitbucket has a leg up on GH.

You have been able to add ?w=1 for years, but it has been in the UI for a while, too.

Screenshot_20200407-212532

@dahlbyk dahlbyk merged commit a160c9a into dahlbyk:master Apr 8, 2020
@rkeithhill
Copy link
Collaborator

Thanks for pointing that out! That has been bugging me for a while. I was looking in the wrong place - in the ... menu to the right of the Viewed button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants