Fixed non-ascii git branch name garbled. #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fullenw1 will you get IOException using new version in your machine? |
dahlbyk
reviewed
Sep 30, 2020
|
How about the new version? |
|
If this still solves the issue you observe, I'm good with it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By 2020, The utf-8 encoding beats the market for any other specified non-single byte encodings for internationalization. In fact, most of Asian developer would prefer utf-8 as the first-class citizens while remaining specified old encoding like gbk, big5, jis as default page code only for windows system compatibly.
#397 @dahlbyk you introduced a bug that it wont't change to utf-8 for non-single byte while you actually want to do it!
After fixed, It will avoid changing output encoding which causing error for single-byte charset users. (but it will return get non utf8 encoding string which make no problem in fact ) #708