Add warning for non-G4W on Windows #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlbyk
force-pushed
the
cygwin-warning
branch
from
fc03a57
to
8aaa2f2
Compare
rkeithhill
reviewed
Oct 29, 2020
src/CheckRequirements.ps1
Outdated
| $script:GitCygwin = $true | ||
|
|
||
| if (!$Env:POSHGIT_CYGWIN_WARNING) { | ||
| Write-Warning "posh-git recommends Git for Windows. You appear to have a different distribution." |
There was a problem hiding this comment.
Can we mention why we recommend Git for Windows? Maybe ... recommends Git for Windows for proper ANSI/VT support. .... or something like that.
There was a problem hiding this comment.
You appear to have an unsupported Git distribution; setting $GitPromptSettings.AnsiConsole = $false. posh-git recommends Git for Windows.
rkeithhill
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#771 suggests we don't want folks using
gitfrom Cygwin. I think we can just check for.windowsingit --version?Set
$Env:POSHGIT_CYGWIN_WARNING = 'false'to hide the warning.