Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Offer class to Activity Vocabulary API #76

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Jun 20, 2024

It resolves a part of #65. It adds Offer class to Activity Vocabulary API.

@moreal moreal marked this pull request as draft June 20, 2024 01:36
Copy link
Owner

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update snapshots for snapshot tests. It can be updated by running deno task test -- --update.

@dahlia dahlia mentioned this pull request Jun 20, 2024
28 tasks
@moreal
Copy link
Contributor Author

moreal commented Jun 20, 2024

@dahlia Thank you! I updated the snapshots and I'll mark as ready-for-review after the checks passed.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (fd936ae) to head (a143a73).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files          39       39           
  Lines        5450     5450           
  Branches      628      628           
=======================================
  Hits         4445     4445           
  Misses        995      995           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moreal
Copy link
Contributor Author

moreal commented Jun 20, 2024

The publish-docs check is failing. It may have an error when using nwtgck/actions-netlify@v3.0 action 🤔 (I cannot see logs). Because #68 is merged though the task was failed in the PR too, I mark this pull request as ready-for-review.

@moreal moreal marked this pull request as ready for review June 20, 2024 02:04
@moreal moreal requested a review from dahlia June 20, 2024 02:06
@dahlia
Copy link
Owner

dahlia commented Jun 20, 2024

The publish-docs check is failing. It may have an error when using nwtgck/actions-netlify@v3.0 action 🤔 (I cannot see logs). Because #68 is merged though the task was failed in the PR too, I mark this pull request as ready-for-review.

That's my fault; I have to fix the CI. Never mind!

@dahlia dahlia merged commit 3d74617 into dahlia:main Jun 20, 2024
9 of 10 checks passed
dahlia added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants