-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Offer
class to Activity Vocabulary API
#76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update snapshots for snapshot tests. It can be updated by running deno task test -- --update
.
@dahlia Thank you! I updated the snapshots and I'll mark as ready-for-review after the checks passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 81.55% 81.55%
=======================================
Files 39 39
Lines 5450 5450
Branches 628 628
=======================================
Hits 4445 4445
Misses 995 995
Partials 10 10 ☔ View full report in Codecov by Sentry. |
The |
That's my fault; I have to fix the CI. Never mind! |
It resolves a part of #65. It adds
Offer
class to Activity Vocabulary API.