-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more missing vocab items #80
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 80.14% 80.12% -0.02%
==========================================
Files 39 39
Lines 5831 5831
Branches 676 676
==========================================
- Hits 4673 4672 -1
- Misses 1146 1147 +1
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contributions! Could you add relevant entries to the changelog (CHANGES.md) and FEDERATION.md?
Absolutely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, all the Markdown files have been reformatted, could you please just add the content without the formatting changes?
Sorry about that, my local lint rules reformatted it. It should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine, I'm going to merge this soon!
In reference to Issue #65
Add:
vocab/arrive.yaml
vocab/invite.yaml
vocab/join.yaml
vocab/leave.yaml
vocab/listen.yaml
Updated the snapshot per the contribution instructions.
I did have to update the snapshots as they were missing some references to the new vocab items
Please verify the snapshots look correct, I would rather not introduce a bad snapshot.
Please reach out if there is anything further I can add to help this land.