Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more missing vocab items #80

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Add more missing vocab items #80

merged 1 commit into from
Jun 28, 2024

Conversation

randy5235
Copy link
Contributor

In reference to Issue #65

Add:
vocab/arrive.yaml
vocab/invite.yaml
vocab/join.yaml
vocab/leave.yaml
vocab/listen.yaml

Updated the snapshot per the contribution instructions.
I did have to update the snapshots as they were missing some references to the new vocab items

Please verify the snapshots look correct, I would rather not introduce a bad snapshot.

Please reach out if there is anything further I can add to help this land.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (3d6cea3) to head (1fd0270).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   80.14%   80.12%   -0.02%     
==========================================
  Files          39       39              
  Lines        5831     5831              
  Branches      676      676              
==========================================
- Hits         4673     4672       -1     
- Misses       1146     1147       +1     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contributions! Could you add relevant entries to the changelog (CHANGES.md) and FEDERATION.md?

@randy5235
Copy link
Contributor Author

Absolutely.

Copy link
Owner

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, all the Markdown files have been reformatted, could you please just add the content without the formatting changes?

@randy5235
Copy link
Contributor Author

Oops, all the Markdown files have been reformatted, could you please just add the content without the formatting changes?

Sorry about that, my local lint rules reformatted it. It should be fixed now.

@randy5235 randy5235 requested a review from dahlia June 27, 2024 05:59
Copy link
Owner

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, I'm going to merge this soon!

@dahlia dahlia merged commit 4a46b61 into dahlia:main Jun 28, 2024
9 of 10 checks passed
@dahlia dahlia mentioned this pull request Jun 28, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants