Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS/feature/24/loading view controller #25

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

HongzCloud
Copy link
Collaborator

기존 로딩뷰 제거 하고 로딩뷰컨트롤러 생성
로딩 뷰 컨트롤러에서 처음 네트워크 처리하도록 함

@HongzCloud HongzCloud added iOS iOS label feat labels Apr 28, 2021
@HongzCloud HongzCloud self-assigned this Apr 28, 2021
@HongzCloud HongzCloud changed the title I os/feature/24/loading view controller iOS/feature/24/loading view controller Apr 28, 2021
@@ -31,7 +31,7 @@ class MenuListViewModel {
.sink(receiveCompletion: { result in
switch result {
case .finished:
break
print("완료 해쪄욤")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프린트문 제거 부탁드립니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다~

@dahun-lee-daji dahun-lee-daji merged commit a69f740 into Dev-iOS Apr 28, 2021
@dahun-lee-daji
Copy link
Owner

고생하셨습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat iOS iOS label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants